Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Increase the full sync timeout #5129

Merged
merged 3 commits into from Sep 13, 2022
Merged

fix(ci): Increase the full sync timeout #5129

merged 3 commits into from Sep 13, 2022

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Sep 11, 2022 •
edited

Motivation

Full syncs are currently failing in CI at about 99.6% with a full sync timeout error.

Solution

  • Increase the timeout from 24 to 28 hours
  • Make a constant for the timeout
  • Update the developer documentation

Review

This is urgent because full syncs are failing on the main branch.
Anyone can review this PR.

Reviewer Checklist

  • CI passes after this PR is merged to main

@teor2345 teor2345 added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-Critical 🚑 I-slow Problems with performance or responsiveness I-integration-fail Continuous integration fails, including build and test failures labels Sep 11, 2022
@teor2345 teor2345 requested a review from a team as a code owner September 11, 2022 21:52
@teor2345 teor2345 self-assigned this Sep 11, 2022
@teor2345 teor2345 requested review from upbqdn and removed request for a team September 11, 2022 21:52
@codecov
Copy link

codecov bot commented Sep 11, 2022 •
edited

Codecov Report

Merging #5129 (293181f) into main (e67452f) will increase coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5129      +/-   ##
==========================================
+ Coverage   79.18%   79.45%   +0.27%     
==========================================
  Files         310      308       -2     
  Lines       39108    39027      -81     
==========================================
+ Hits        30966    31008      +42     
+ Misses       8142     8019     -123

@teor2345 teor2345 mentioned this pull request Sep 11, 2022
Merged
3 tasks
@teor2345
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Sep 12, 2022

refresh

✅ Pull request refreshed

@teor2345
Copy link
Contributor Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Sep 12, 2022

update

✅ Branch has been successfully updated

@mergify mergify bot mentioned this pull request Sep 13, 2022
Closed
mergify bot added a commit that referenced this pull request Sep 13, 2022
@mergify
Merge of #5129
fcc71f2
This was referenced Sep 13, 2022
Closed
Closed
mergify bot added a commit that referenced this pull request Sep 13, 2022
@mergify
Merge of #5129
a98a84a
@mergify mergify bot mentioned this pull request Sep 13, 2022
Closed
mergify bot added a commit that referenced this pull request Sep 13, 2022
@mergify
Merge of #5129
9007ab8
@mergify mergify bot mentioned this pull request Sep 13, 2022
Closed
@mergify mergify bot merged commit dcbbf44 into main Sep 13, 2022
@mergify mergify bot deleted the up-full-sync-timeout branch September 13, 2022 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upbqdn upbqdn upbqdn approved these changes

@gustavovalverde gustavovalverde gustavovalverde approved these changes

Assignees

@teor2345 teor2345

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug I-integration-fail Continuous integration fails, including build and test failures I-slow Problems with performance or responsiveness
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teor2345 @upbqdn @gustavovalverde